LICENSE should be inserted in all required files. If there’s a short version possible I’d prefer it over a long bulky text at the top of every file.
Installing -> this needs you to run doctrine:schema:create and mapbender:resetroot now as the standard configuration uses the DB for storing users/roles.
UPDATING: The changes for the Manager backend break updates for the master branch - There’s a special MapbenderBundle class to use for, ehm, Mapbender bundles. - Elements and Layer API has changed a bit (I’d say it got unlittered).
Especially the WMS and WMTS layer classes had Geoportal.DE specific code in them. Big No-GO!
This implies that projects already started will need work to use the new Manager backend based Mapbender.
User registration: There’s Geoportal.DE specific stuff in the CoreBundleControllerUserController class (e-mail adresses and stuff.) I would like to suggest: - The UserController of the CoreBundle should just handle login/logout,
nothing more.
Symfony Update: Once 2.1 is ready I want to upgrade to it. It has some nice things which will be useful. We should consider moving more of the Symfony stuff as an external dependency (repository-wise). I would like someone to investigate if we can use Composer (getcomposer.org) for easier dependency management.
I have found project specific stuff in the CoreBundle. This should not have happened. Therefore I would like to propose monthly code reviews where people take responsibility for the code and mark code to be refactored/reworked on. I would like to split up the responsibility. Given the nature that much of the API has been my brain-fart, I will take responsibility for the following components:
This leaves the following components open to adoption:
All of these include providing custom forms to be used in the Manager backend.
This is very basic for now:
There’s always more to do...